Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CE-1059-database-changes #83

Merged
merged 6 commits into from
Sep 17, 2024
Merged

feat: CE-1059-database-changes #83

merged 6 commits into from
Sep 17, 2024

Conversation

afwilcox
Copy link
Collaborator

@afwilcox afwilcox commented Sep 11, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

CE-1063 (Partial Fix to CE-1059)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Contains data model changes to make the Non-Compliance Decision Matrix code optional on the table.

Also included is a missing FK that I spotted while making this change.

Also included is better handling of null values from the user for the Rationale and NCDM fields.

Also included is work to allow the action information to be nullable

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Attempt to create Decision without a rationale or NCDM

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@afwilcox afwilcox changed the title CE-1059-database-changes feat: CE-1059-database-changes Sep 11, 2024
marqueone-ps
marqueone-ps previously approved these changes Sep 13, 2024
mde updates to the create and update decision mutations to correctly create and update actions when selected
@afwilcox afwilcox added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 2d2c8c5 Sep 17, 2024
9 checks passed
@afwilcox afwilcox deleted the CE-1059-database-changes branch September 17, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants